Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector-Competition-Fix: Fix/Remove QuickMetrics (shutdown) #1997

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Detector-Competition-Fix: Fix/Remove QuickMetrics (shutdown) #1997

merged 9 commits into from
Oct 26, 2023

Conversation

lc
Copy link
Contributor

@lc lc commented Oct 25, 2023

Description:

QuickMetrics has shutdown – https://quickmetrics.io/. Also, the API no longer resolves: qckm.io

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@lc lc requested a review from a team as a code owner October 25, 2023 16:22
@dustin-decker dustin-decker added the Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition label Oct 25, 2023
@rgmz rgmz mentioned this pull request Oct 25, 2023
Closed
32 tasks
@rosecodym
Copy link
Collaborator

Do you mind adding [deprecated = true] to the relevant enum case in detectors.proto and rerunning make protos? (docs) I see you have some other deletion PRs open - you can do that for the relevant enum cases in those as well.

@lc
Copy link
Contributor Author

lc commented Oct 25, 2023

Done for this detector.

0x1
0x1 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@0x1 0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ty for the contribution!

@0x1 0x1 merged commit f796026 into trufflesecurity:main Oct 26, 2023
8 of 9 checks passed
Phoenix591 pushed a commit to Phoenix591/trufflehog that referenced this pull request Oct 27, 2023
@lc @0x1 @Phoenix591
Detector-Competition-Fix: Fix/Remove QuickMetrics (shutdown) (truffle…
0b8cadf 
…security#1997)

* Detector-Competition-Fix: Fix/Remove QuickMetrics (shutdown)

* Detector-Competition-Fix: Fix/Remove QuickMetrics protos

* make protos for deprecating Blablabus (trufflesecurity#2002)

* make protos for deprecating quickmetrics

---------

Co-authored-by: āh̳̕med <[email protected]>
Co-authored-by: ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x1 0x1 0x1 approved these changes

Assignees
No one assigned
Labels
Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lc @rosecodym @0x1 @dustin-decker