-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Domains Used by Detectors #1998
Comments
@rgmz What if we add a function in Scanner{} to verify if host exists? This way, we can add a Github Action check to verify if any detector needs to be removed. WDYT? |
This could be automated to an extent: subdomains that no longer resolve or domains that have expired are easy to check, behavioral changes are a bit harder. I am curious whether the team has an existing process to run all the |
We have established a daily routine where an automated test suite is executed to assess the performance of our detectors, identifying any failures. However, a segment of these failures is attributed to the expiration of test tokens, which were configured during trial phases. Our current focus is on devising strategies to segregate genuine test failures from those arising due to expired credentials. Furthermore, we are in the preliminary stages of broadening our metrics around detection to garner more insights into the issue at hand. As our detector arsenal expands, acquiring a deeper understanding of each detector's performance and validity becomes paramount. The experiences from this month alone have highlighted a noticeable count of detectors falling into obsolescence, reinforcing the necessity of this endeavor. 😅 This approach to automation, especially concerning the verification of subdomains and domain expirations, should hopefully aid in filtering out trivial issues, allowing us to prioritize addressing more complex behavioral changes. |
Description
Since @lc is doing a great job validating existing detectors, I figured it would be useful to do a high-level check of any domains that no longer resolve or are expired.
I will continue to update this list with findings.
Broken
This could indicate that the specific endpoint is broken and needs attention (e.g., Gitter) or that the domain itself is no longer registered/resolves.
trufflehog/pkg/detectors/apiscience/apiscience.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/datafire/datafire.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/gitter/gitter.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/happi/happi.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/lexigram/lexigram.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/flowdock/flowdock.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/macaddress/macaddress.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/metaapi/metaapi.go
Line 60 in 6c35dcf
https://isitwater-com.p.rapidapi.com
)trufflehog/pkg/detectors/onwaterio/onwaterio.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/opengraphr/opengraphr.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/passbase/passbase.go
Line 50 in 6c35dcf
https://localhost/metadata
despite https://www.sherpadesk.com/ being alive??)trufflehog/pkg/detectors/sherpadesk/sherpadesk.go
Line 54 in 6c35dcf
trufflehog/pkg/detectors/unifyid/unifyid.go
Line 52 in 6c35dcf
trufflehog/pkg/detectors/fakejson/fakejson.go
Line 53 in 6c35dcf
trufflehog/pkg/detectors/lendflow/lendflow.go
Line 54 in 6c35dcf
trufflehog/pkg/detectors/quickmetrics/quickmetrics.go
Line 51 in 6c35dcf
trufflehog/pkg/detectors/impala/impala.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/scrapersite/scrapersite.go
Line 53 in 6c35dcf
trufflehog/pkg/detectors/liveagent/liveagent.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/glitterlyapi/glitterlyapi.go
Line 50 in 6c35dcf
trufflehog/pkg/detectors/scrapersite/scrapersite.go
Line 53 in 6c35dcf
Parked
Other
The text was updated successfully, but these errors were encountered: