Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed ordering of arguments #1648

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix reversed ordering of arguments #1648

merged 1 commit into from
Aug 22, 2023

Commits on Aug 21, 2023

  1. Fix reversed ordering of arguments

    The source manager initialization function was defined as `sourceID`
    followed by `jobID`, while the source initialization function is the
    reverse. This is confusing and easy to mix up since the parameters are
    the same type.
    
    This commit adds a test to make sure the source manager initializes in
    the correct order, but it doesn't prevent the library user to make the
    same mistake. We may want to consider using different types.
    mcastorina committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2f8d21e View commit details
    Browse the repository at this point in the history