Fix reversed ordering of arguments #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source manager initialization function was defined as `sourceID` followed by `jobID`, while the source initialization function is the reverse. This is confusing and easy to mix up since the parameters are the same type. This commit adds a test to make sure the source manager initializes in the correct order, but it doesn't prevent the library user to make the same mistake. We may want to consider using different types.
|
The code using the library was in the correct order: trufflehog/pkg/engine/circleci.go Line 31 in 2f8d21e trufflehog/pkg/engine/docker.go Line 16 in 2f8d21e trufflehog/pkg/engine/filesystem.go Line 28 in 2f8d21e Line 48 in 2f8d21e Line 55 in 2f8d21e trufflehog/pkg/engine/github.go Line 51 in 2f8d21e trufflehog/pkg/engine/gitlab.go Line 54 in 2f8d21e Line 62 in 2f8d21e trufflehog/pkg/engine/syslog.go Line 45 in 2f8d21e |
rosecodym
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source manager initialization function was defined as
sourceIDfollowed byjobID, while the source initialization function is the reverse. This is confusing and easy to mix up since the parameters are the same type.This commit adds a test to make sure the source manager initializes in the correct order, but it doesn't prevent the library user to make the same mistake. We may want to consider using different types.