Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D Potential Temperature Formulation for the Euler Eqs. #38

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

minor changes

6c91b29
Select commit
Loading
Failed to load commit list.
Open

Add 2D Potential Temperature Formulation for the Euler Eqs. #38

minor changes
6c91b29
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 25, 2024 in 1s

77.87% (-3.91%) compared to 223fefe

View this Pull Request on Codecov

77.87% (-3.91%) compared to 223fefe

Details

Codecov Report

Attention: Patch coverage is 63.05419% with 75 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (223fefe) to head (6c91b29).

Files with missing lines Patch % Lines
...ons/compressible_euler_potential_temperature_2d.jl 60.00% 72 Missing ⚠️
src/equations/compressible_moist_euler_2d_lucas.jl 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   81.78%   77.87%   -3.91%     
==========================================
  Files           8        9       +1     
  Lines         829     1008     +179     
==========================================
+ Hits          678      785     +107     
- Misses        151      223      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.