Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D Potential Temperature Formulation for the Euler Eqs. #38

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

MarcoArtiano
Copy link
Collaborator

This PR adds the Potential Temperature formulation for the Euler Eqs., where the energy equation has been substituted with the evolution of the potential temperature. The equations have been tested on the warm bubble dry test. The fluxes LMARS and an entropy conservative flux (total energy conserving) have been also added.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 63.05419% with 75 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (223fefe) to head (6c91b29).

Files with missing lines Patch % Lines
...ons/compressible_euler_potential_temperature_2d.jl 60.00% 72 Missing ⚠️
src/equations/compressible_moist_euler_2d_lucas.jl 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   81.78%   77.87%   -3.91%     
==========================================
  Files           8        9       +1     
  Lines         829     1008     +179     
==========================================
+ Hits          678      785     +107     
- Misses        151      223      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add the new elixir to the tests so that the new code runs as well in CI?

src/TrixiAtmo.jl Outdated Show resolved Hide resolved
@MarcoArtiano
Copy link
Collaborator Author

Thanks! Could you please add the new elixir to the tests so that the new code runs as well in CI?

Thanks! Could you please add the new elixir to the tests so that the new code runs as well in CI?

Yep, thanks for the reminder! The test has been added now.

src/equations/equations.jl Outdated Show resolved Hide resolved
examples/elixir_moist_euler_dry_bubble.jl Outdated Show resolved Hide resolved
examples/elixir_moist_euler_moist_bubble.jl Outdated Show resolved Hide resolved
examples/elixir_moist_euler_moist_bubble.jl Outdated Show resolved Hide resolved
src/TrixiAtmo.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants