Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p4est solver on a spherical mesh #25

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

amrueda
Copy link
Collaborator

@amrueda amrueda commented Jul 26, 2024

This PR implements a version of the 2D p4est solver that runs on a spherical shell that is constructed from a cubed sphere. Since there are three Cartesian space dimensions on the surface of the sphere, we use the 2D p4est solver in combination with a 3D equation.

The connectivities are inherited from the p8est 3D cubed-sphere implementation, but they are adapted to p4est (2D). The discretization strategy follows the approach by:

The following visualization uses this version of Trixi2Vtk:

earth.mp4

…tion in Trixi.jl (cherry-picked from f45378e)

Co-authored-by: Tristan Montoya <[email protected]>
@amrueda amrueda marked this pull request as draft July 26, 2024 13:13
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 258 lines in your changes missing coverage. Please review.

Project coverage is 19.32%. Comparing base (7241ff6) to head (bb2b1b2).
Report is 1 commits behind head on main.

Files Patch % Lines
src/meshes/p4est_cubed_sphere.jl 0.00% 153 Missing ⚠️
...olvers/dgsem_p4est/containers_2d_manifold_in_3d.jl 0.00% 77 Missing ⚠️
...vers/dgsem_p4est/dg_2d_manifold_in_3d_cartesian.jl 0.00% 20 Missing ⚠️
...semidiscretization_hyperbolic_2d_manifold_in_3d.jl 0.00% 5 Missing ⚠️
src/solvers/dgsem_p4est/dg.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   28.07%   19.32%   -8.75%     
==========================================
  Files           3        8       +5     
  Lines         570      828     +258     
==========================================
  Hits          160      160              
- Misses        410      668     +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ltype() and ndims() functions for new struct
@tristanmontoya
Copy link
Member

I've added my covariant solver to this PR in https://github.com/trixi-framework/TrixiAtmo.jl/tree/tm/p4est_new_container

@tristanmontoya tristanmontoya marked this pull request as ready for review August 15, 2024 09:37
@tristanmontoya tristanmontoya marked this pull request as draft August 15, 2024 09:38
@tristanmontoya
Copy link
Member

@amrueda I think we can merge this even if the dimension check isn't removed from the main Trixi.jl package yet, since my covariant solver will use it.

@amrueda amrueda marked this pull request as ready for review August 15, 2024 11:31
@amrueda amrueda changed the title WIP: p4est solver on a spherical mesh p4est solver on a spherical mesh Aug 15, 2024
Copy link
Member

@tristanmontoya tristanmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this now; tests will be added for the Cartesian solver once the dimension check in Trixi.jl is moved out of the inner constructor for SemidiscretizationHyperbolic.

@tristanmontoya tristanmontoya merged commit 302acc5 into main Aug 15, 2024
7 of 10 checks passed
@tristanmontoya tristanmontoya deleted the arr/spherical_shell branch August 15, 2024 19:56
@ranocha
Copy link
Member

ranocha commented Aug 16, 2024

I'm going to merge this now; tests will be added for the Cartesian solver once the dimension check in Trixi.jl is moved out of the inner constructor for SemidiscretizationHyperbolic.

The new version of Trixi.jl including the fix is released

@tristanmontoya
Copy link
Member

I'm going to merge this now; tests will be added for the Cartesian solver once the dimension check in Trixi.jl is moved out of the inner constructor for SemidiscretizationHyperbolic.

The new version of Trixi.jl including the fix is released

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants