Hll 2 wave improvements non breaking #1561

DanielDoehring · 2023-07-06T12:43:35Z

This tries to implement the non-breaking part of #1545 as suggested in #1545 (review) . As such, the MHD equations still bear the name min_max_speed_naive for the min_max_speed_einfeldt.

This reverts commit 047a5e7.

Co-authored-by: Hendrik Ranocha <[email protected]>

…rixi.jl into HLL_2_Wave_Improvements

ranocha

Great, thanks a lot! Please find some comments below.

examples/structured_1d_dgsem/elixir_euler_sedov_hll_davis.jl

src/equations/numerical_fluxes.jl

test/test_unit.jl

src/equations/ideal_glm_mhd_1d.jl

src/equations/ideal_glm_mhd_2d.jl

src/equations/ideal_glm_mhd_3d.jl

test/test_unit.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

DanielDoehring · 2023-07-12T13:24:14Z

And please resolve the conflicts

Done in 67c318c.

codecov · 2023-07-12T14:23:53Z

Codecov Report

Merging #1561 (1e8bef9) into main (42732db) will increase coverage by 14.24%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1561       +/-   ##
===========================================
+ Coverage   81.94%   96.18%   +14.24%     
===========================================
  Files         370      370               
  Lines       31153    31426      +273     
===========================================
+ Hits        25526    30224     +4698     
+ Misses       5627     1202     -4425

Flag	Coverage Δ
unittests	`96.18% <100.00%> (+14.24%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
examples/dgmulti_2d/elixir_euler_bilinear.jl	`100.00% <ø> (ø)`
examples/dgmulti_2d/elixir_euler_curved.jl	`100.00% <ø> (ø)`
examples/dgmulti_2d/elixir_euler_weakform.jl	`100.00% <ø> (ø)`
examples/dgmulti_3d/elixir_euler_curved.jl	`100.00% <ø> (ø)`
examples/dgmulti_3d/elixir_euler_weakform.jl	`100.00% <ø> (ø)`
src/Trixi.jl	`50.00% <ø> (+9.09%)`	⬆️
src/equations/numerical_fluxes.jl	`84.71% <ø> (ø)`
src/equations/compressible_euler_1d.jl	`97.29% <100.00%> (+5.83%)`	⬆️
src/equations/compressible_euler_2d.jl	`99.12% <100.00%> (+9.38%)`	⬆️
src/equations/compressible_euler_3d.jl	`97.05% <100.00%> (+18.16%)`	⬆️
... and 6 more

... and 92 files with indirect coverage changes

ranocha

Coverage decreased as you can see in the report of coveralls

You can click on it and find the files where this PR decreases coverage. For example, min_max_speed_naive is not tested for LinearizedEulerEquations2D. The shallow water files also show a reduced coverage. Could you please add some tests for these?

…elDoehring/Trixi.jl into HLL_2_Wave_Improvements_NonBreaking

DanielDoehring · 2023-07-13T11:23:42Z

Coverage decreased as you can see in the report of coveralls

You can click on it and find the files where this PR decreases coverage. For example, min_max_speed_naive is not tested for LinearizedEulerEquations2D. The shallow water files also show a reduced coverage. Could you please add some tests for these?

Done, now everything is green :)

ranocha

Thanks a lot!

DanielDoehring and others added 26 commits June 20, 2023 18:17

Add Classical and Naive HLL 2 Wave solver to classic Hyperbolic PDEs

c6882c7

Format Code

0b74c59

HLLE wave speeds for SWE

0288814

Fix typos

1145f9f

Update tests for HLL

3ce5b3b

Unit test 1D MHD HLL, HLLE

2364017

Add example for classical HLL 2 wave

6c64eba

remove plots

9de6fac

Use lowercase for flux

b10b54d

Use einfeldt for mhd

2c14c35

Use hlle for mhd tets

85403b1

Missing comma causes failing tests

f068fd0

Correct bug in SWE 2D Roe eigval comp, unit tests

d184578

format

047a5e7

Revert "format"

3e5c402

This reverts commit 047a5e7.

format equations

ce72be0

Add unit tests for HLL naive

f7b2b1e

Revert default hll flux

f1e7f5b

Rename min_max_speed to min_max_speed_davis and reduce documentation

5a03dfa

Merge branch 'main' into HLL_2_Wave_Improvements

36e9c5e

Update src/equations/shallow_water_1d.jl: Comments

7cfc22c

Co-authored-by: Hendrik Ranocha <[email protected]>

Add published resource for Roe averages for SWE

ef6d070

Merge branch 'HLL_2_Wave_Improvements' of github.com:DanielDoehring/T…

c079f2c

…rixi.jl into HLL_2_Wave_Improvements

Add tests for rotation

f741306

Remove breaking portionv from PR

227332e

fix copy paste error

b575bda

DanielDoehring mentioned this pull request Jul 6, 2023

Hll 2 wave improvements #1545

Closed

Lowercase davis

9f93a4b

ranocha added the enhancement New feature or request label Jul 12, 2023

ranocha requested changes Jul 12, 2023

View reviewed changes

DanielDoehring and others added 15 commits July 12, 2023 12:53

Update src/equations/numerical_fluxes.jl

4438a7c

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/numerical_fluxes.jl

29dcc45

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/numerical_fluxes.jl

8626d56

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/numerical_fluxes.jl

1c3a237

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/numerical_fluxes.jl

ff46046

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/numerical_fluxes.jl

d849e51

Co-authored-by: Hendrik Ranocha <[email protected]>

Update test/test_tree_2d_mhd.jl

0d5194e

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/ideal_glm_mhd_1d.jl

4f88249

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/ideal_glm_mhd_2d.jl

4cca8fa

Co-authored-by: Hendrik Ranocha <[email protected]>

Update src/equations/ideal_glm_mhd_3d.jl

6606c30

Co-authored-by: Hendrik Ranocha <[email protected]>

Update test/test_tree_3d_mhd.jl

579a7ef

Co-authored-by: Hendrik Ranocha <[email protected]>

Remove hll_davis test

747b767

Split consistency checks

8dff75c

Try to resolve conflict with 5ff677c

1cd90eb

Merge branch 'main' into HLL_2_Wave_Improvements_NonBreaking

67c318c

ranocha requested changes Jul 12, 2023

View reviewed changes

DanielDoehring added 3 commits July 13, 2023 09:01

Add tests

af134d4

Merge branch 'HLL_2_Wave_Improvements_NonBreaking' of github.com:Dani…

b9e1b74

…elDoehring/Trixi.jl into HLL_2_Wave_Improvements_NonBreaking

More tests

1e8bef9

DanielDoehring requested a review from ranocha July 13, 2023 11:24

ranocha approved these changes Jul 13, 2023

View reviewed changes

ranocha merged commit a191e39 into trixi-framework:main Jul 13, 2023
30 checks passed

DanielDoehring deleted the HLL_2_Wave_Improvements_NonBreaking branch July 14, 2023 06:30

JoshuaLampert mentioned this pull request Aug 9, 2023

Davis wave speed estimate for shallow water equations #1601

Merged

This was referenced Sep 22, 2023

Implement the Davis signal speeds in HLL solver for compressible Euler equations, #180

Closed

Estimates of wave speeds #134

Open

DanielDoehring mentioned this pull request Nov 6, 2023

HLL MHD Breaking changes for Consistency #1708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hll 2 wave improvements non breaking #1561

Hll 2 wave improvements non breaking #1561

DanielDoehring commented Jul 6, 2023

ranocha left a comment

DanielDoehring commented Jul 12, 2023 •

edited

Loading

codecov bot commented Jul 12, 2023 •

edited

Loading

ranocha left a comment

DanielDoehring commented Jul 13, 2023 •

edited

Loading

ranocha left a comment

Hll 2 wave improvements non breaking #1561

Hll 2 wave improvements non breaking #1561

Conversation

DanielDoehring commented Jul 6, 2023

ranocha left a comment

Choose a reason for hiding this comment

DanielDoehring commented Jul 12, 2023 • edited Loading

codecov bot commented Jul 12, 2023 • edited Loading

Codecov Report

ranocha left a comment

Choose a reason for hiding this comment

DanielDoehring commented Jul 13, 2023 • edited Loading

ranocha left a comment

Choose a reason for hiding this comment

DanielDoehring commented Jul 12, 2023 •

edited

Loading

codecov bot commented Jul 12, 2023 •

edited

Loading

DanielDoehring commented Jul 13, 2023 •

edited

Loading