Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Davis signal speeds in HLL solver for compressible Euler equations, #180

Closed
gregorgassner opened this issue Sep 10, 2020 · 1 comment
Closed

Implement the Davis signal speeds in HLL solver for compressible Euler equations, #180

gregorgassner opened this issue Sep 10, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gregorgassner
Copy link
Contributor

Ssl = min(vl - cl, vr - cr) and Ssr = max(vr+cr, vl+cl)

to guarantee that Ssl is smaller than Ssr

than the "symmetry fix" for the if statements is not necessary anymore...
@gregorgassner gregorgassner added enhancement New feature or request good first issue Good for newcomers labels Sep 10, 2020
@DanielDoehring
Copy link
Contributor

See #1561, #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregorgassner @DanielDoehring