Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ach and creditCard icons #3788

Merged
merged 2 commits into from
Aug 9, 2023
Merged

feat: add ach and creditCard icons #3788

merged 2 commits into from
Aug 9, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Aug 9, 2023

FX-4229

Description

This pull request adds ach24 and creditCard24 icons so all the icons have both 16px and 24px variants.

How to test

Screenshots

Screenshot 2023-08-09 at 12 48 58 Screenshot 2023-08-09 at 12 48 52

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Aug 9, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 8825166

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk changed the title feat: add icons feat: add ach and creditCar icons Aug 9, 2023
@sashuk sashuk changed the title feat: add ach and creditCar icons feat: add ach and creditCard icons Aug 9, 2023
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 11:00 Inactive
@sashuk sashuk marked this pull request as ready for review August 9, 2023 11:00
@sashuk sashuk requested a review from a team August 9, 2023 11:00
@sashuk sashuk mentioned this pull request Aug 9, 2023
9 tasks
@sashuk
Copy link
Contributor Author

sashuk commented Aug 9, 2023

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 11:10 Inactive
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 11:25 Inactive
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 11:43 Inactive
@mkrl mkrl requested a review from a team August 9, 2023 12:05
@sashuk sashuk merged commit 0367170 into master Aug 9, 2023
12 checks passed
@sashuk sashuk deleted the FX-NULL-add-icons branch August 9, 2023 13:09
@toptal-build toptal-build mentioned this pull request Aug 9, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants