-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make CircularButton responsive #3785
fix: make CircularButton responsive #3785
Conversation
🦋 Changeset detectedLatest commit: b533415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also change the stories of the Page where we use the buttons in the header? 🤔
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
774e3ec
to
2c9ca8d
Compare
I've updated this PR to take |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works good! The minor comment in #3785 (comment) left
f62994a
to
ca4bd09
Compare
4c3b037
to
b533415
Compare
* feat: make CircularButton responsive * feat: responsive is off by default * chore: remove outdated changeset
* feat: make CircularButton responsive * feat: responsive is off by default * chore: remove outdated changeset
FX-4179
Description
According to BASE design, icons acting as buttons should accommodate for bigger icons.
How to test
Button
storyResponsive
story for theCircularButton
Screenshots
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?