feat: add occupied slots to game rooms api #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
reviewed
Oct 9, 2024
| @@ -130,6 +130,7 @@ type GameRoom struct { | |||
| IsValidationRoom bool | |||
| LastPingAt time.Time | |||
| CreatedAt time.Time | |||
| OccupiedSlots int | |||
There was a problem hiding this comment.
nit: why don't we use the same naming as the proto? IMO it would simplify maintenance and they seem to map 1:1, right?
hspedro
reviewed
Oct 9, 2024
| @@ -130,6 +130,7 @@ type GameRoom struct { | |||
| IsValidationRoom bool | |||
| LastPingAt time.Time | |||
| CreatedAt time.Time | |||
| OccupiedSlots int | |||
There was a problem hiding this comment.
nit: why don't we use the same naming as the proto? IMO it would simplify maintenance and they seem to map 1:1, right?
hspedro
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the changes to allow Maestro calculations to be based on the number of matches running in a Game Server.
These changes will allow maestro to receive the number of running matches in a Game Server.
Changes
running_matchesparam to the service definition files (proto)