Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update binaryen submodule to version 114 #3882

Closed
wants to merge 1 commit into from

Conversation

DarkByteBen
Copy link
Contributor

This change upgrades the binaryen submodule from version 102 to version 114.

Resolves #3881

One consideration before merging is that the newer version of binaryen requires a submodule initialized under third_party/googletest. If this change is fine as is, great, but I'm not sure if there might be other documentation or files that need to account for that.

@deadprogram
Copy link
Member

Hello @DarkByteBen

I think there are some other changes needed to fully pick up the update.

https://github.com/tinygo-org/tinygo/blob/dev/.github/workflows/linux.yml#L355
I think this needs to be git submodule update --init --recursive lib/binaryen in order to update the submodule's submodules.

https://github.com/tinygo-org/tinygo/blob/dev/.github/workflows/linux.yml#L345-L350
We need to change the cache key to binaryen-linux-arm-v2

There are some other similar changes that will be needed for all the GH jobs.

Searching the repo source for binaryen should turn up more places like the above.

@ayang64
Copy link
Contributor

ayang64 commented Sep 28, 2023

@deadprogram - This would be useful for getting tinygo to compile under FreeBSD as the current version of the binaryen fails to build.

It is a small error -- clang stops at a bitwise OR (|) that was supposed to be a boolean OR (||) -- but this appears to be fixed in later versions.

This was referenced Oct 16, 2023
@deadprogram
Copy link
Member

Superseded by #3958 so now closing. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants