Update binaryen submodule #3957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure latest version of binaryen is used by GH actions on linux. Required to fix issue#3881 Signed-off-by: Flavio Castelli <[email protected]>
Signed-off-by: Flavio Castelli <[email protected]>
|
@deadprogram: this time all the tests seems to be passing. Let me know if there's something else I should do |
|
Hello @flavio thanks for picking this up. Just wondering if we want to update to binaryen 116 since that just came out last month? https://github.com/WebAssembly/binaryen/releases/tag/version_116 |
|
Since 116 is the version currently being installed by homebrew, seems like a good idea to update to that one. |
Signed-off-by: Flavio Castelli <[email protected]>
|
@deadprogram: I renamed my branch to match the version of binaryen being used, but that lead to this PR to be closed. I've opened a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3882 which seems to be no longer active.
I've run into issue #3881 too, this is why I would like to see this fix merged.
I've rebased the original PR against latest
devbranch, and applied the requests from this comment.I've searched for other places inside of the GitHub actions where the binaryen code is checkout out, but this seems to be specific to Linux. On Mac/Windows the binaryen binaries are installed via package managers (brew and scoop).