Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid private access to loaded_precompile #856

Merged
merged 3 commits into from
Oct 10, 2024
Merged

avoid private access to loaded_precompile #856

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c954b30
avoid private access to loaded_precompile
vtjnash Oct 5, 2024
9741a4a
Update loading.jl
vtjnash Oct 7, 2024
32bba77
Update src/loading.jl
KristofferC Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
@assert reqs !== nothing
pkgdata.requirements = reqs
for chi in includes
if isdefined(Base, :loaded_precompiles) && haskey(Base.loaded_precompiles, id => buildid)
mod = Base.loaded_precompiles[id => buildid]
if isdefined(Base, :maybe_loaded_precompile) && Base.maybe_loaded_precompile(id, buildid)
vtjnash marked this conversation as resolved.
Show resolved Hide resolved
mod = Base.maybe_loaded_precompile(id, buildid)

Check warning on line 47 in src/loading.jl

View check run for this annotation

Codecov / codecov/patch

src/loading.jl#L47 

Added line #L47 was not covered by tests
else
mod = Base.root_module(id)
end
Expand Down
Loading