avoid private access to loaded_precompile #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Oct 7, 2024
vtjnash
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 7, 2024
If we expect this to be a public API (https://github.com/timholy/Revise.jl for some reason is trying to access this state), we should lock around it for consistency with the other similar functions. Needed for timholy/Revise.jl#856
topolarity
reviewed
Oct 9, 2024
Co-authored-by: Cody Tapscott <[email protected]>
|
I believe the nightly failure is because nightly is not new enough (it's missing JuliaLang/julia#56027) |
|
Weird it hasn't been updated in two days. |
|
I think Pkg is broken on v1.11, so the upload jobs have been failing for a couple days, if I read the logs right |
|
I've tested master locally and it passes - Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.