Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Stdout to TestReloadLabel #8427

Merged
merged 3 commits into from
Jul 23, 2024
Merged

test: add Stdout to TestReloadLabel #8427

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f7aa64
add log
okJiang Jul 22, 2024
6228c1e
Merge branch 'master' of github.com:tikv/pd into fix-8389
okJiang Jul 22, 2024
12e5479
Merge branch 'master' into fix-8389
ti-chi-bot[bot] Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/integrations/realcluster/reboot_pd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package realcluster

import (
"context"
"os"
"os/exec"
"testing"

Expand All @@ -26,6 +27,8 @@ import (
func restartTiUP() {
log.Info("start to restart TiUP")
cmd := exec.Command("make", "deploy")
cmd.Stdout = os.Stdout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the current output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exec.Command creates a child process, so it will output on the child process's terminal.

cmd.Stderr = os.Stderr
err := cmd.Run()
if err != nil {
panic(err)
Expand Down