test: add Stdout to TestReloadLabel #8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8427 +/- ##
==========================================
+ Coverage 77.26% 77.32% +0.05%
==========================================
Files 471 471
Lines 61907 61907
==========================================
+ Hits 47833 47868 +35
+ Misses 10487 10456 -31
+ Partials 3587 3583 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
rleungx
reviewed
Jul 22, 2024
| @@ -26,6 +27,8 @@ import ( | |||
| func restartTiUP() { | |||
| log.Info("start to restart TiUP") | |||
| cmd := exec.Command("make", "deploy") | |||
| cmd.Stdout = os.Stdout | |||
There was a problem hiding this comment.
exec.Command creates a child process, so it will output on the child process's terminal.
HuSharp
approved these changes
Jul 23, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
rleungx
approved these changes
Jul 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8389 (comment)
What is changed and how does it work?
Check List
Tests
complete test
Release note