Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for clone unmarshal #8308

Merged
merged 2 commits into from
Jun 19, 2024
Merged

test: add test for clone unmarshal #8308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f8de24
add test
HuSharp Jun 19, 2024
6f56dbc
Merge branch 'master' into add_rukle_key_test
HuSharp Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions client/http/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,3 +308,30 @@ func mustMarshalAndUnmarshalRuleOp(re *require.Assertions, ruleOp *RuleOp) *Rule
re.NoError(err)
return newRuleOp
}

// startKey and endKey are json:"-" which means cannot be Unmarshal from json
// We need to take care of `Clone` method.
func TestRuleKeyClone(t *testing.T) {
re := require.New(t)
r := &Rule{
StartKey: []byte{1, 2, 3},
EndKey: []byte{4, 5, 6},
}

clone := r.Clone()
// Modify the original rule
r.StartKey[0] = 9
r.EndKey[0] = 9

// The clone should not be affected
re.Equal([]byte{1, 2, 3}, clone.StartKey)
re.Equal([]byte{4, 5, 6}, clone.EndKey)

// Modify the clone
clone.StartKey[0] = 8
clone.EndKey[0] = 8

// The original rule should not be affected
re.Equal([]byte{9, 2, 3}, r.StartKey)
re.Equal([]byte{9, 5, 6}, r.EndKey)
}
27 changes: 27 additions & 0 deletions pkg/schedule/placement/rule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,30 @@ func TestBuildRuleList(t *testing.T) {
re.Equal(testCase.expect.ranges, result.ranges)
}
}

// startKey and endKey are json:"-" which means cannot be Unmarshal from json
// We need to take care of `Clone` method.
func TestRuleKeyClone(t *testing.T) {
re := require.New(t)
r := &Rule{
StartKey: []byte{1, 2, 3},
EndKey: []byte{4, 5, 6},
}

clone := r.Clone()
// Modify the original rule
r.StartKey[0] = 9
r.EndKey[0] = 9

// The clone should not be affected
re.Equal([]byte{1, 2, 3}, clone.StartKey)
re.Equal([]byte{4, 5, 6}, clone.EndKey)

// Modify the clone
clone.StartKey[0] = 8
clone.EndKey[0] = 8

// The original rule should not be affected
re.Equal([]byte{9, 2, 3}, r.StartKey)
re.Equal([]byte{9, 5, 6}, r.EndKey)
}