-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for clone unmarshal #8308
Conversation
Signed-off-by: husharp <[email protected]>
@okJiang PTAL, thx! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8308 +/- ##
==========================================
- Coverage 77.41% 77.28% -0.14%
==========================================
Files 470 470
Lines 61324 61392 +68
==========================================
- Hits 47473 47445 -28
- Misses 10287 10387 +100
+ Partials 3564 3560 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@HuSharp: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
issue relies on
76b4932#diff-5cf563058fdae91ee59093d5721fde21b45888669570a5fdfd54bbe502ce3e03L93-L95
We have this logic for
clone
pd/client/http/types.go
Lines 366 to 373 in 13174b5
This is because startKey is json:"-" which means cannot be Unmarshal from json, We need to take care of
Clone
method.pd/client/http/types.go
Lines 346 to 349 in 13174b5
Check List
Tests
Release note