fix: change traffic light topic name #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
1222-takeshi
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901,
zulfaqar-azmi-t4,
miursh,
YoshiRi and
yukkysaito
as code owners
1222-takeshi
removed request for
mkuri,
yukkysaito,
rej55,
YoshiRi,
takayuki5168,
TakaHoribe,
soblin,
kyoichi-sugahara,
miursh and
kosuke55
1222-takeshi
requested review from
Naophis
and removed request for
purewater0901,
satoshi-ota,
taikitanaka3,
zulfaqar-azmi-t4 and
TomohitoAndo
1222-takeshi
changed the title
1222-takeshi
changed the title
|
ありがとうございます！！！！ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
behavior_velocityで
を使っているので上記をtraffic_lightモジュールの最終出力としたが、
以下のPRでtraffic_lightモジュールの最終出力は
であるほうがよく、behavior_velocityのinputを変えたほうがよい。となったのでtraffic_light、behavior_velocityのtopic名を修正
Related links
autowarefoundation#4133
autowarefoundation#4393
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.