Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queries for zos4 on nodes/farms endpoint #1209

Open
Tracked by #1569
AhmedHanafy725 opened this issue Sep 25, 2024 · 1 comment
Open
Tracked by #1569

Add queries for zos4 on nodes/farms endpoint #1209

AhmedHanafy725 opened this issue Sep 25, 2024 · 1 comment
Assignees
Labels
grid-proxy belongs to grid proxy type_feature New feature or request
Milestone

Comments

@AhmedHanafy725
Copy link
Contributor

AhmedHanafy725 commented Sep 25, 2024

Is your feature request related to a problem? Please describe

some networks are not supported on zos4 so we need queries to filter them.

Describe the solution you'd like

add queries for the node if it supports:

  • wireguard
  • yggdrasil
  • public ips

Also, please add them as fields on the node object

same queries should be added too to the farms' queries

@AhmedHanafy725 AhmedHanafy725 added type_feature New feature or request grid-proxy belongs to grid proxy labels Sep 25, 2024
@AhmedHanafy725 AhmedHanafy725 changed the title Add queries for zos4 on nodes endpoint Add queries for zos4 on nodes/farms endpoint Sep 25, 2024
@Omarabdul3ziz Omarabdul3ziz self-assigned this Sep 25, 2024
@Omarabdul3ziz Omarabdul3ziz added this to the v0.16.0 milestone Sep 25, 2024
@Omarabdul3ziz
Copy link
Contributor

after the discussion, i think having a filter features and node_features which takes a list of features and filter the nodes that support it will be more suitable for the usecase.

  • /nodes?features=network,zmachine,zdb
  • /nodes?features=zmachine-light,network-light

and in the node response will add the full list of the supported features

no need for wg/ygg/pubIp filters in that case, knowing that network-light nodes doesn't support them.

is that okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid-proxy belongs to grid proxy type_feature New feature or request
Projects
Status: In Verification
Development

No branches or pull requests

2 participants