Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init the features indexer #1214

Merged
merged 3 commits into from
Oct 2, 2024
Merged

init the features indexer #1214

merged 3 commits into from
Oct 2, 2024

Conversation

Omarabdul3ziz
Copy link
Contributor

  • modify the node response to have the supported features
  • add the features indexer to the list of indexers health
  • support filtering nodes based on its features
  • support filtering farms based on its nodes' features
  • add the indexer work that calls the node and decide its have a light network version or the normal one
  • decide a full day as the interval for the features indexer
  • update swagger docs with the new filters
  • add random value generators for the new filters
  • add the test conditions for the new filter tests
  • add the new table to schema and add a dump generator and loader
  • Add queries for zos4 on nodes/farms endpoint #1209

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@Omarabdul3ziz
init the features indexer:
da3f24b 
- modify the node response to have the supported features
- add the features indexer to the list of indexers health
- support filtering nodes based on its features
- support filtering farms based on its nodes' features
- add the indexer work that calls the node and decide its have a light network version or the normal one
- decide a full day as the interval for the features indexer
- update swagger docs with the new filters
- add random value generators for the new filters
- add the test conditions for the new filter tests
- add the new table to schema and add a dump generator and loader
@xmonader
Copy link
Contributor

image

Can we discuss? Seems that we only care here about wg, ygg, public ip only? afaik there're changes for other workloads

I was expecting that we will have the version and the node features (all of them) indexed somehow

@Omarabdul3ziz
refactor the feature indexer to include all features:
b1dbd00 
- add validation on the nodefeature filter values
- add the features filter/field to the node and farm getters methods
- update the feature indexer parser to include the feature set to the report
- update swagger docs
- fix the nullable features to be an empty slice instead
- add the feature indexer to health state
- add a helper methods file
- update schema/generator/loader/tests
@Omarabdul3ziz
chores:
59429ea 
- add enhance notes
- create function for common checks
@Omarabdul3ziz Omarabdul3ziz merged commit ebb7050 into development Oct 2, 2024
39 checks passed
@Omarabdul3ziz Omarabdul3ziz deleted the main_features_indexer branch October 2, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@ashraffouda ashraffouda ashraffouda approved these changes

@MarioBassem MarioBassem Awaiting requested review from MarioBassem MarioBassem is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@AbdelrahmanElawady AbdelrahmanElawady Awaiting requested review from AbdelrahmanElawady AbdelrahmanElawady is a code owner

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk sameh-farouk is a code owner

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara Eslam-Nawara is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Omarabdul3ziz @xmonader @ashraffouda