Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zos4 deployments #3462

Open
Tracked by #1569
AhmedHanafy725 opened this issue Sep 25, 2024 · 2 comments
Open
Tracked by #1569

Support zos4 deployments #3462

AhmedHanafy725 opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@AhmedHanafy725
Copy link
Contributor

AhmedHanafy725 commented Sep 25, 2024

Which package/s are you suggesting this feature for?

Dashboard, grid_client

Is your feature request related to a problem? Please describe

There are now 2 different zos on the nodes (zos3, zos4), so the dashboard and grid client should identify the node zos version and use the corresponding workloads to deploy on them.

zos4 currently doesn't support wireguad, yggdrasil, or public ips. so it will require these filters from the grid proxy to be supported threefoldtech/tfgrid-sdk-go#1209

Describe the solution you'd like

  • 2 new workloads should be added

  • Before starting the deployment, the grid client should check the node version and decide which workloads to be used to deploy the vm and network.

  • Adjust the automatic and manual filters to respect the newly added queries on the gridproxy to suggest valid nodes for deployment.

@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Sep 29, 2024
@0oM4R
Copy link
Contributor

0oM4R commented Sep 29, 2024

  • we just need to add the new network filters in the gridclient, and on manual filter we need to check if the node support the selected options
  • we need to handle listing as well, how to list zos4 workloads

start with the workloads till we have filters ready on gridproxy

@maayarosama
Copy link
Contributor

  1. Work Completed:
  • Added workloads for zmachinelight and network light
  • Added Unit tests for both
  1. Work in Progress (WIP):
  • Trying to figure out why I can't import newly added workloads even after building
  • Adding new filters in grid_client
  • On deploying checking the node features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants