Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Ecosystem account linking #4733

Merged
merged 1 commit into from
Sep 21, 2024

[SDK] Feature: Ecosystem account linking (#4733)

824b1bd
Select commit
Loading
Failed to load commit list.
Merged

[SDK] Feature: Ecosystem account linking #4733

[SDK] Feature: Ecosystem account linking (#4733)
824b1bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 21, 2024 in 1s

49.21% (-1.40%) compared to 6e3669d

View this Pull Request on Codecov

49.21% (-1.40%) compared to 6e3669d

Details

Codecov Report

Attention: Patch coverage is 13.46154% with 90 lines in your changes missing coverage. Please review.

Project coverage is 49.21%. Comparing base (6e3669d) to head (824b1bd).

Files with missing lines Patch % Lines
...b/src/wallets/in-app/core/wallet/ecosystem-core.ts 22.85% 27 Missing ⚠️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 8.33% 22 Missing ⚠️
...eb/ui/ConnectWallet/screens/ManageWalletScreen.tsx 6.25% 15 Missing ⚠️
.../wallets/in-app/core/authentication/linkAccount.ts 6.66% 14 Missing ⚠️
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 0.00% 6 Missing ⚠️
...hirdweb/src/wallets/in-app/core/wallet/profiles.ts 20.00% 4 Missing ⚠️
...hirdweb/src/react/core/hooks/others/useProfiles.ts 50.00% 1 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4733      +/-   ##
==========================================
- Coverage   50.61%   49.21%   -1.40%     
==========================================
  Files        1024     1046      +22     
  Lines       54578    56556    +1978     
  Branches     3888     3892       +4     
==========================================
+ Hits        27624    27836     +212     
- Misses      26321    28087    +1766     
  Partials      633      633              
Files with missing lines Coverage Δ
...hirdweb/src/react/core/hooks/others/useProfiles.ts 35.71% <50.00%> (+4.94%) ⬆️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 12.62% <0.00%> (ø)
...hirdweb/src/wallets/in-app/core/wallet/profiles.ts 5.00% <20.00%> (+5.00%) ⬆️
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 9.78% <0.00%> (ø)
.../wallets/in-app/core/authentication/linkAccount.ts 4.41% <6.66%> (+1.33%) ⬆️
...eb/ui/ConnectWallet/screens/ManageWalletScreen.tsx 13.27% <6.25%> (+0.54%) ⬆️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 16.84% <8.33%> (-2.88%) ⬇️
...b/src/wallets/in-app/core/wallet/ecosystem-core.ts 25.00% <22.85%> (+1.53%) ⬆️

... and 20 files with indirect coverage changes