Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Ecosystem account linking #4733

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Sep 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to enable account linking for ecosystem wallets.

Detailed summary

  • Added support for linking profiles in ecosystem wallets
  • Updated conditions for multi-auth support in ecosystem wallets
  • Implemented functions to handle ecosystem wallets in various components
  • Updated authentication and profile retrieval for ecosystem wallets

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 824b1bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:11am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:11am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:11am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:11am

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 573 ms (+40.68% 🔺) 1.5 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 765 ms (+14.39% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 139 ms (+290.83% 🔺) 236 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 37 ms (+10.91% 🔺) 47 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 172 ms (+58.96% 🔺) 507 ms

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 13.46154% with 90 lines in your changes missing coverage. Please review.

Project coverage is 49.21%. Comparing base (6e3669d) to head (824b1bd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/wallets/in-app/core/wallet/ecosystem-core.ts 22.85% 27 Missing ⚠️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 8.33% 22 Missing ⚠️
...eb/ui/ConnectWallet/screens/ManageWalletScreen.tsx 6.25% 15 Missing ⚠️
.../wallets/in-app/core/authentication/linkAccount.ts 6.66% 14 Missing ⚠️
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 0.00% 6 Missing ⚠️
...hirdweb/src/wallets/in-app/core/wallet/profiles.ts 20.00% 4 Missing ⚠️
...hirdweb/src/react/core/hooks/others/useProfiles.ts 50.00% 1 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4733      +/-   ##
==========================================
- Coverage   50.61%   49.21%   -1.40%     
==========================================
  Files        1024     1046      +22     
  Lines       54578    56556    +1978     
  Branches     3888     3892       +4     
==========================================
+ Hits        27624    27836     +212     
- Misses      26321    28087    +1766     
  Partials      633      633              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6e3669d
packages 45.29% <13.46%> (-1.57%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/core/hooks/others/useProfiles.ts 35.71% <50.00%> (+4.94%) ⬆️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 12.62% <0.00%> (ø)
...hirdweb/src/wallets/in-app/core/wallet/profiles.ts 5.00% <20.00%> (+5.00%) ⬆️
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 9.78% <0.00%> (ø)
.../wallets/in-app/core/authentication/linkAccount.ts 4.41% <6.66%> (+1.33%) ⬆️
...eb/ui/ConnectWallet/screens/ManageWalletScreen.tsx 13.27% <6.25%> (+0.54%) ⬆️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 16.84% <8.33%> (-2.88%) ⬇️
...b/src/wallets/in-app/core/wallet/ecosystem-core.ts 25.00% <22.85%> (+1.53%) ⬆️

... and 20 files with indirect coverage changes

Copy link

graphite-app bot commented Sep 21, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enables account linking for ecosystem wallets.

### Detailed summary
- Added support for ecosystem wallets in account linking functionality
- Updated conditions for multi-auth support in various components
- Imported and utilized `isEcosystemWallet` function in multiple files
- Modified functions to handle both in-app and ecosystem wallets in account linking operations

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants