-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(playground): checkbox ids and passkey TOS approval #4308
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
423fd4c
to
90d3244
Compare
Merge activity
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
=======================================
Coverage 59.57% 59.58%
=======================================
Files 968 968
Lines 78462 78464 +2
Branches 3541 3541
=======================================
+ Hits 46747 46754 +7
+ Misses 31040 31035 -5
Partials 675 675
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to add a `disabled` prop to various components for improved user interaction control. ### Detailed summary - Added `disabled` prop to `WalletTypeRowButton` component - Added `disabled` prop to `ConnectWalletSocialOptions` component - Updated checkbox label in `LeftSection` component > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
35b76e2
to
c12da72
Compare
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview The focus of this PR is to add a `disabled` prop to various components for better control over user interactions. ### Detailed summary - Added `disabled` prop to `WalletTypeRowButton` component in `WalletTypeRowButton.tsx` - Added `disabled` prop to `ConnectWalletSocialOptions` component in `ConnectWalletSocialOptions.tsx` - Added `disabled` prop to different options in `ConnectWalletSocialOptions` component - Updated label and ID in `LeftSection.tsx` for TOS approval checkbox > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
c12da72
to
e14af15
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
The focus of this PR is to add a
disabled
prop to various components for better user interaction control.Detailed summary
disabled
prop toWalletTypeRowButton
component inWalletTypeRowButton.tsx
disabled
prop to components inConnectWalletSocialOptions.tsx
id
attribute and label text inLeftSection.tsx
for clarity