Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): checkbox ids and passkey TOS approval #4308

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Aug 28, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to add a disabled prop to various components for better user interaction control.

Detailed summary

  • Added disabled prop to WalletTypeRowButton component in WalletTypeRowButton.tsx
  • Added disabled prop to components in ConnectWalletSocialOptions.tsx
  • Updated id attribute and label text in LeftSection.tsx for clarity

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Aug 28, 2024 9:56pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 9:56pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 9:56pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 9:56pm

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: e14af15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Aug 28, 2024
@gregfromstl gregfromstl force-pushed the hotfix/fix-playground-checkbox-id branch from 423fd4c to 90d3244 Compare August 28, 2024 19:41
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 28, 2024 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 28, 2024 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 28, 2024 19:41 Inactive
@gregfromstl gregfromstl added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. labels Aug 28, 2024
Copy link

graphite-app bot commented Aug 28, 2024

Merge activity

  • Aug 28, 3:43 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 3:45 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 3:46 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 3:50 PM EDT: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 28, 4:57 PM EDT: gregfromstl added this pull request to the Graphite merge queue.
  • Aug 28, 5:20 PM EDT: gregfromstl merged this pull request with the Graphite merge queue.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (fcf8f89) to head (e14af15).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...react/web/ui/ConnectWallet/WalletTypeRowButton.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4308   +/-   ##
=======================================
  Coverage   59.57%   59.58%           
=======================================
  Files         968      968           
  Lines       78462    78464    +2     
  Branches     3541     3541           
=======================================
+ Hits        46747    46754    +7     
+ Misses      31040    31035    -5     
  Partials      675      675           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fcf8f89
packages 58.60% <50.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...react/web/ui/ConnectWallet/WalletTypeRowButton.tsx 40.00% <50.00%> (+0.41%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Aug 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.25 KB (0%) 865 ms (0%) 452 ms (+43.15% 🔺) 1.4 s
thirdweb (cjs) 92.03 KB (0%) 1.9 s (0%) 896 ms (+26.71% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 4.81 KB (0%) 97 ms (0%) 83 ms (+164.55% 🔺) 179 ms
thirdweb/chains (tree-shaking) 492 B (0%) 10 ms (0%) 43 ms (+747.23% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 16.06 KB (0%) 322 ms (0%) 117 ms (+221.53% 🔺) 439 ms

gregfromstl added a commit that referenced this pull request Aug 28, 2024
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
The focus of this PR is to add a `disabled` prop to various components for improved user interaction control.

### Detailed summary
- Added `disabled` prop to `WalletTypeRowButton` component
- Added `disabled` prop to `ConnectWalletSocialOptions` component
- Updated checkbox label in `LeftSection` component

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the hotfix/fix-playground-checkbox-id branch from 35b76e2 to c12da72 Compare August 28, 2024 20:57
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
The focus of this PR is to add a `disabled` prop to various components for better control over user interactions.

### Detailed summary
- Added `disabled` prop to `WalletTypeRowButton` component in `WalletTypeRowButton.tsx`
- Added `disabled` prop to `ConnectWalletSocialOptions` component in `ConnectWalletSocialOptions.tsx`
- Added `disabled` prop to different options in `ConnectWalletSocialOptions` component
- Updated label and ID in `LeftSection.tsx` for TOS approval checkbox

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the hotfix/fix-playground-checkbox-id branch from c12da72 to e14af15 Compare August 28, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. packages Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants