Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(playground): checkbox ids and passkey TOS approval #4308

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(playground): checkbox ids and passkey TOS approval #4308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions apps/playground-web/src/app/connect/sign-in/button/LeftSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export function LeftSection(props: {
{/* Require Approval */}
<section className="flex items-center gap-2">
<Checkbox
id="show-thirdweb-branding"
id="require-approval"
checked={connectOptions.requireApproval}
onCheckedChange={(checkState) => {
setConnectOptions((v) => ({
Expand All @@ -176,9 +176,7 @@ export function LeftSection(props: {
}));
}}
/>
<Label htmlFor="show-thirdweb-branding">
Require TOS approval
</Label>
<Label htmlFor="require-approval">Require TOS approval</Label>
</section>
</div>
</div>
Expand Down
2 changes: 2 additions & 0 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/WalletTypeRowButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
onClick: () => void;
title: string;
icon: string;
disabled?: boolean;
};

export function WalletTypeRowButton(props: WalletTypeRowProps) {
Expand All @@ -29,6 +30,7 @@
onClick={() => {
props.onClick();
}}
disabled={props.disabled}

Check warning on line 33 in packages/thirdweb/src/react/web/ui/ConnectWallet/WalletTypeRowButton.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/WalletTypeRowButton.tsx#L33 

Added line #L33 was not covered by tests
>
<Container flex="row" gap="sm" center="y" color="accentText">
<Img
Expand Down
3 changes: 3 additions & 0 deletions packages/thirdweb/src/react/web/wallets/shared/ConnectWalletSocialOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ export const ConnectWalletSocialOptions = (
setManualInputMode("email");
}}
title={locale.emailPlaceholder}
disabled={props.disabled}
/>
)}
</>
Expand Down Expand Up @@ -409,6 +410,7 @@ export const ConnectWalletSocialOptions = (
setManualInputMode("phone");
}}
title={locale.phonePlaceholder}
disabled={props.disabled}
/>
)}
</>
Expand All @@ -423,6 +425,7 @@ export const ConnectWalletSocialOptions = (
handlePassKeyLogin();
}}
title={locale.passkey}
disabled={props.disabled}
/>
</>
)}
Expand Down
Loading