Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.yml: update Zephyr to 1f55be8b42df #8945

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

LaurentiuM1234
Copy link
Contributor

@LaurentiuM1234 LaurentiuM1234 commented Mar 14, 2024

Zephyr PR#70219 changes i.MX8ULP's SOC name to MIMX8UD7. As such, we need to update the board configuration file and the SOC name inside xtensa-build-zephyr.py to use the new SOC name.

This is just a clone of zephyrproject-rtos#43.

EDIT: also added changes from zephyrproject-rtos#44 to this PR.

@LaurentiuM1234 LaurentiuM1234 added the DNM Do Not Merge tag label Mar 14, 2024
@LaurentiuM1234 LaurentiuM1234 changed the title nxp: imx8ulp: change SOC name to MIMX8UD7 [DNM] nxp: imx8ulp: change SOC name to MIMX8UD7 Mar 14, 2024
@LaurentiuM1234
Copy link
Contributor Author

FYI @kv2019i @marc-hb in case any 8ULP-related CI build failures creep their way in because of zephyrproject-rtos/zephyr#70219

@LaurentiuM1234 LaurentiuM1234 changed the title [DNM] nxp: imx8ulp: change SOC name to MIMX8UD7 nxp: imx8ulp: change SOC name to MIMX8UD7 Mar 28, 2024
@LaurentiuM1234 LaurentiuM1234 removed the DNM Do Not Merge tag label Mar 28, 2024
@LaurentiuM1234 LaurentiuM1234 marked this pull request as ready for review March 28, 2024 13:27
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this Zephyr upgrade should fix the daily tests where zmain just started failing:

https://github.com/thesofproject/sof/actions/runs/8475478210

A few changes requested though:

  • Please squash everything in a single commit so every SOF commit still builds.
  • For the commit message please keep re-using the same format, run git log -- west.yml for examples. A short summary of Zephyr changes that affect SOF is desired. It does not have to be perfect and exhaustive but please try.
  • The current PR title is about the SOC name change but for most users the biggest change is probably the west.yml change. Yet they will ignore a PR that seems very NXP-specific.

@LaurentiuM1234 LaurentiuM1234 changed the title nxp: imx8ulp: change SOC name to MIMX8UD7 west.yml: update Zephyr to 36ad49bd6500 Apr 1, 2024
@LaurentiuM1234
Copy link
Contributor Author

Thanks, this Zephyr upgrade should fix the daily tests where zmain just started failing:

https://github.com/thesofproject/sof/actions/runs/8475478210

A few changes requested though:

  • Please squash everything in a single commit so every SOF commit still builds.
  • For the commit message please keep re-using the same format, run git log -- west.yml for examples. A short summary of Zephyr changes that affect SOF is desired. It does not have to be perfect and exhaustive but please try.
  • The current PR title is about the SOC name change but for most users the biggest change is probably the west.yml change. Yet they will ignore a PR that seems very NXP-specific.

Changes should be addressed in this new version. LMK if there's still stuff left to address.

FYI @kv2019i. This hash bump should also contain changes from #8981

@marc-hb marc-hb dismissed their stale review April 1, 2024 14:12

stale review

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 1, 2024

@wszypelt , @lrudyX : MTL and LNL tests did not run in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8945/build13803550 because of some "connection refused", can you please take a look?

MTL was all green in https://sof-ci.01.org/sofpr/PR8945/build3704/devicetest/index.html and whatever cAVS we have left in https://sof-ci.01.org/sofpr/PR8945/build3705/devicetest/index.html was green too.

Contains the following squashed SOF commits:

nxp: imx8ulp: change SOC name to MIMX8UD7
zephyr: CMakeLists.txt use new `CONFIG_SOC_C` for 8ULP
cmake: update configs for NXP ADSP

and the following Zephyr patches affecting SOF:

951763939034 nxp: imx8ulp: change SOC name to MIMX8UD7
b8214b673970 dts: xtensa: nxp_imx8: add SAI1 node
a0e32f07ef76 dts: intel_adsp: ace: update host dma copy alignment
3fde2c50c6ef tracing: add intel ADSP memory window backend
6b9d01f995c7 intel_adsp/ace: power: No pending transaction before power gate
6ea749de5283 arch: rename arch_start_cpu() to arch_cpu_start()
b69d2486fee6 kernel: rename Z_KERNEL_STACK_BUFFER to K_KERNEL_STACK_BUFFER
1f55be8b42df nxp: imx8: change CONFIG_SOC_<name> to match the value
688fbb53aeb2 intel_adsp: ace: Fix sparse error

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Signed-off-by: Iuliana Prodan <[email protected]>
@LaurentiuM1234 LaurentiuM1234 changed the title west.yml: update Zephyr to 36ad49bd6500 west.yml: update Zephyr to 1f55be8b42df Apr 2, 2024
@LaurentiuM1234
Copy link
Contributor Author

LaurentiuM1234 commented Apr 2, 2024

Included changes from #9000. Needed because changes from zephyrproject-rtos/zephyr#70772 break zmain build.

@dbaluta dbaluta merged commit f0740ed into thesofproject:main Apr 2, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants