Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config validation via TypeBox schema. #449

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Commits on Jun 11, 2024

  1. TypeBox Schema for the Config file...

    This is the most boring and demotivating thing I have done in
    awhile. Jesus christ, I hated this and it took me so long
    just to convince myself to start copy and pasting things.
    
    And I don't know why
    Gnuxie committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    da033e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Report validation errors.

    This has failed miserably because for some reason transform errors
    are reported differently to schema validation errors. They aren't
    treated like a TypeBox `ValueError`.
    
    `Config.util.extendDeep` also for some obscure reason introduces
    `null`s when objects such as `sentry` are undefined,
    so the schema had to be changed for that.
    Gnuxie committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    044e13f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbe4825 View commit details
    Browse the repository at this point in the history