Config validation via TypeBox schema. #449
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the most boring and demotivating thing I have done in awhile. Jesus christ, I hated this and it took me so long just to convince myself to start copy and pasting things. And I don't know why
This has failed miserably because for some reason transform errors are reported differently to schema validation errors. They aren't treated like a TypeBox `ValueError`. `Config.util.extendDeep` also for some obscure reason introduces `null`s when objects such as `sentry` are undefined, so the schema had to be changed for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #217.
This whole exercise was miserable and has failed, sadly (read commit messages).
https://matrix.to/#/%23draupnir%3Amatrix.org/%24FDjyJ_bxlqx6lW5Ce74RfpDQpYxT973fddywBtyNJQY?via=matrix.org&via=envs.net&via=ubuntu.com
Following up I think the best course of action is to first figure out how to report transform errors correctly (or stop using transforms).
And also migrate the config to a new format behind the scenes that can be validated more easily*.
What we mean by this is we create a new format, which we encourage everyone to use, but the old format can still be loaded just fine and is migrated to the new one transparently until they change to the new format. Which we will detect with a version number