-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e asset problems #3653
Comments
There were 10 tests disabled across 2 spec files.
Feedback on these potential changes would be appreciated. |
For the
|
Non-bundled assets can be successfully uploaded to teraslice. But when you try to register a job that uses the asset you will get the same |
Side note: |
This PR makes the following changes: - Replace old style assets in e2e tests with bundled assets. - Re-enable tests that were failing because of those assets. - Remove 2 tests that checked if different types of old style assets could be used. ref: #3653
In the e2e fixtures are zip files of assets. These are old legacy assets to do not work with the latest changes to teraslice. In the code most of it was to test the asset structure and loading of operations which is not really where this test should live. It should live in job-components.
We decided (me, Austin, Peter, Joseph) to bypass those tests that reference those assets for now. We need to later review which tests should live in e2e vs job-components (assuming we don't have those types of tests in job-components) and re-enable tests that are still useful to in e2e.
The text was updated successfully, but these errors were encountered: