Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework e2e test assets #3666

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Rework e2e test assets #3666

merged 4 commits into from
Jun 28, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jun 21, 2024 •
edited
Loading

This PR makes the following changes:

  • Replace old style assets in e2e tests with bundled assets.
  • Re-enable tests that were failing because of those assets.
  • Remove 2 tests that checked if different types of old style assets could be used.

ref: #3653

@busma13 busma13 marked this pull request as ready for review June 25, 2024 15:06
@busma13 busma13 requested review from sotojn and godber June 25, 2024 15:06
@godber godber added this to the v2.1 milestone Jun 25, 2024
@godber godber merged commit fd147a8 into master Jun 28, 2024
59 checks passed
@godber godber deleted the rework-e2e-test-assets branch June 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@sotojn sotojn Awaiting requested review from sotojn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @godber