Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old style assets should be rejected at upload #3663

Closed
busma13 opened this issue Jun 18, 2024 · 1 comment
Closed

Old style assets should be rejected at upload #3663

busma13 opened this issue Jun 18, 2024 · 1 comment
Assignees

Comments

@busma13
Copy link
Contributor

busma13 commented Jun 18, 2024

While looking into another issue (#3653) I was looking at the assets used in e2e tests. They are the old style that is both non-bundled and has processors, schemas, etc in one index.js file. These assets no longer work with teraslice v2.0.0 because the operation-loader fails when it tries to require processor.[js/cjs/mjs].

We should add a check at asset upload to check for and reject these older assets instead of waiting for a failure when we register a job that uses the asset.

@busma13 busma13 self-assigned this Jun 18, 2024
@busma13
Copy link
Contributor Author

busma13 commented Jun 21, 2024

I didn't find a reliable way to differentiate between asset styles that wasn't slow. The only way I could come up with was to look for a processor.js or schema.js, but these files can be deep in the file tree, which took some time to find.

@busma13 busma13 closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant