Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint and packages updates #1239

Merged
merged 5 commits into from
Sep 6, 2024
Merged

eslint and packages updates #1239

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8eb2af9
update eslint and packages
jsnoble Sep 5, 2024
79a796e
update semver
jsnoble Sep 5, 2024
04858c9
fix eslint call and ignore dist folder
jsnoble Sep 6, 2024
1aa049e
fix yarn.lock
jsnoble Sep 6, 2024
e284dde
have consistensty for asset includes
jsnoble Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .eslintrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion asset/asset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "elasticsearch",
"version": "4.0.3"
"version": "4.0.4"
}
8 changes: 4 additions & 4 deletions asset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "asset",
"displayName": "Asset",
"version": "4.0.3",
"version": "4.0.4",
"private": true,
"description": "",
"license": "MIT",
Expand All @@ -20,10 +20,10 @@
"dependencies": {
"@terascope/data-mate": "^1.0.3",
"@terascope/elasticsearch-api": "^4.0.1",
"@terascope/elasticsearch-asset-apis": "^1.0.2",
"@terascope/job-components": "^1.2.0",
"@terascope/elasticsearch-asset-apis": "^1.0.3",
"@terascope/job-components": "^1.2.1",
"@terascope/teraslice-state-storage": "^1.0.1",
"@terascope/utils": "^1.0.0",
"@terascope/utils": "^1.0.1",
"datemath-parser": "^1.0.6",
"got": "^13.0.0",
"moment": "^2.30.1"
Expand Down
6 changes: 6 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import eslintConfig from '@terascope/eslint-config';
// need to probably put this in original eslint-config
// don't lint the dist folder
eslintConfig[0].ignores.push('dist/');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asset has a dist folder too.

Suggested change
eslintConfig[0].ignores.push('dist/');
eslintConfig[0].ignores.push('dist/');
eslintConfig[0].ignores.push('asset/dist/');

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put that in though its not needed for this, the build just happens to keep this in line, as mentioned in the comments, I will be removing these and putting them back in the eslint-config package itself so this is temporary


export default eslintConfig
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "elasticsearch-assets",
"displayName": "Elasticsearch Assets",
"version": "4.0.3",
"version": "4.0.4",
"private": true,
"description": "bundle of processors for teraslice",
"homepage": "https://github.com/terascope/elasticsearch-assets#readme",
Expand Down Expand Up @@ -29,7 +29,7 @@
"docker:limit": "./scripts/docker-limit-check.sh",
"docker:listImages": "ts-scripts images list",
"docker:saveImages": "ts-scripts images save",
"lint": "eslint --ignore-path .gitignore --ext .js,.ts .",
"lint": "eslint",
"lint:fix": "yarn lint --fix",
"publish:changed": "./scripts/publish.sh",
"setup": "yarn && yarn build --force",
Expand All @@ -45,20 +45,20 @@
},
"dependencies": {},
"devDependencies": {
"@terascope/data-types": "^1.0.0",
"@terascope/data-types": "^1.0.1",
"@terascope/elasticsearch-api": "^4.0.1",
"@terascope/elasticsearch-asset-apis": "^1.0.2",
"@terascope/eslint-config": "^0.8.0",
"@terascope/job-components": "^1.2.0",
"@terascope/elasticsearch-asset-apis": "^1.0.3",
"@terascope/eslint-config": "^1.0.0",
"@terascope/job-components": "^1.2.1",
"@terascope/scripts": "1.0.2",
"@terascope/teraslice-state-storage": "^1.0.1",
"@terascope/types": "^1.0.0",
"@terascope/types": "^1.0.1",
"@types/bluebird": "^3.5.38",
"@types/got": "^9.6.12",
"@types/jest": "^29.5.12",
"@types/node": "^20.14.6",
"@types/node": "^22.5.4",
"elasticsearch-store": "^1.0.4",
"eslint": "^8.57.0",
"eslint": "^9.9.1",
"jest": "^29.6.4",
"jest-extended": "^4.0.2",
"moment": "^2.30.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/elasticsearch-asset-apis/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@terascope/elasticsearch-asset-apis",
"displayName": "Elasticsearch Asset Apis",
"version": "1.0.2",
"version": "1.0.3",
"description": "Elasticsearch reader and sender apis",
"homepage": "https://github.com/terascope/elasticsearch-assets",
"repository": "[email protected]:terascope/elasticsearch-assets.git",
Expand All @@ -27,9 +27,9 @@
},
"dependencies": {
"@terascope/data-mate": "^1.0.3",
"@terascope/data-types": "^1.0.0",
"@terascope/data-types": "^1.0.1",
"@terascope/elasticsearch-api": "^4.0.1",
"@terascope/utils": "^1.0.0",
"@terascope/utils": "^1.0.1",
"datemath-parser": "^1.0.6",
"got": "^13.0.0",
"moment": "^2.30.1"
Expand Down
Loading