-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint and packages updates #1239
Conversation
eslint.config.js
Outdated
import eslintConfig from '@terascope/eslint-config'; | ||
// need to probably put this in original eslint-config | ||
// don't lint the dist folder | ||
eslintConfig[0].ignores.push('dist/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asset has a dist folder too.
eslintConfig[0].ignores.push('dist/'); | |
eslintConfig[0].ignores.push('dist/'); | |
eslintConfig[0].ignores.push('asset/dist/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put that in though its not needed for this, the build just happens to keep this in line, as mentioned in the comments, I will be removing these and putting them back in the eslint-config package itself so this is temporary
"@typescript-eslint/no-duplicate-enum-values": "warn", | ||
"import/extensions": "off", | ||
"import/no-import-module-exports": "off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we choosing to use the defaults for no-duplicate-enum-values
and no-import-module-exports
or are these handled somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are handled in the eslin-config library, remember these are just overrides, we have not touched the library for a very long time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.