Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint and packages updates #1239

Merged
merged 5 commits into from
Sep 6, 2024
Merged

eslint and packages updates #1239

merged 5 commits into from
Sep 6, 2024

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Sep 5, 2024

No description provided.

eslint.config.js Outdated
import eslintConfig from '@terascope/eslint-config';
// need to probably put this in original eslint-config
// don't lint the dist folder
eslintConfig[0].ignores.push('dist/');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asset has a dist folder too.

Suggested change
eslintConfig[0].ignores.push('dist/');
eslintConfig[0].ignores.push('dist/');
eslintConfig[0].ignores.push('asset/dist/');

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put that in though its not needed for this, the build just happens to keep this in line, as mentioned in the comments, I will be removing these and putting them back in the eslint-config package itself so this is temporary

Comment on lines -9 to -11
"@typescript-eslint/no-duplicate-enum-values": "warn",
"import/extensions": "off",
"import/no-import-module-exports": "off"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we choosing to use the defaults for no-duplicate-enum-values and no-import-module-exports or are these handled somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are handled in the eslin-config library, remember these are just overrides, we have not touched the library for a very long time

Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busma13 busma13 merged commit acf449f into master Sep 6, 2024
15 checks passed
@busma13 busma13 deleted the esm-packages-updates branch September 6, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants