Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the linux part of the firmware script #500

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

sharpenedblade
Copy link
Contributor

It should work better now, and doesnt mess with mounts

@AdityaGarg8
Copy link
Member

I actually was thinking of making binaries that run only in macOS using pyinstaller.

It would make a .tar file in macOS itself then.

Copy link
Member

@AdityaGarg8 AdityaGarg8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use python3 on macOS since it's not shipped with it. User will have to install python3. So, either ship a binary with macOS or use Linux to rename.

@sharpenedblade sharpenedblade force-pushed the update-firmware-script branch 2 times, most recently from c68f9f2 to b17443c Compare February 15, 2024 05:23
@sharpenedblade
Copy link
Contributor Author

We cannot use python3 on macOS since it's not shipped with it. User will have to install python3. So, either ship a binary with macOS or use Linux to rename.

/usr/bin/python3 is from apple for me, it might be xcode dev tools but that can be installed in 1 command (xcode-select --install).

@AdityaGarg8
Copy link
Member

We cannot use python3 on macOS since it's not shipped with it. User will have to install python3. So, either ship a binary with macOS or use Linux to rename.

/usr/bin/python3 is from apple for me, it might be xcode dev tools but that can be installed in 1 command (xcode-select --install).

So we don't want user to install anything as far as macOS is considered.

docs/tools/firmware.sh Show resolved Hide resolved
@AdityaGarg8
Copy link
Member

Also, don't make the user install any additional software on macOS, that includes python3

@sharpenedblade
Copy link
Contributor Author

Also, don't make the user install any additional software on macOS, that includes python3

I am going to try to embed python, but that makes the firmware script huge and it needs custom build steps which are very finicky. The python packaging ecosystem is a huge mess, and apple makes it very hard to distribute stuff on macos.

@sharpenedblade sharpenedblade marked this pull request as draft February 17, 2024 19:14
@AdityaGarg8
Copy link
Member

Also, don't make the user install any additional software on macOS, that includes python3

I am going to try to embed python, but that makes the firmware script huge and it needs custom build steps which are very finicky. The python packaging ecosystem is a huge mess, and apple makes it very hard to distribute stuff on macos.

Or we could just use Linux to rename. I had said I'll prefer macOS, but since embedding python is difficult, it's better to stay on Linux.

@AdityaGarg8
Copy link
Member

And if we want to embed, I guess pyinstaller is perfect for this scenario.

@sharpenedblade sharpenedblade marked this pull request as ready for review February 17, 2024 21:54
@sharpenedblade
Copy link
Contributor Author

This just uses new mountpoints now, I will make a new PR with the python script running on macos

docs/tools/firmware.sh Outdated Show resolved Hide resolved
docs/tools/firmware.sh Outdated Show resolved Hide resolved
docs/tools/firmware.sh Outdated Show resolved Hide resolved
docs/tools/firmware.sh Outdated Show resolved Hide resolved
docs/tools/firmware.sh Outdated Show resolved Hide resolved
@sharpenedblade sharpenedblade force-pushed the update-firmware-script branch 2 times, most recently from 56bf3e0 to 32a15fd Compare February 23, 2024 05:44
@sharpenedblade
Copy link
Contributor Author

I fixed the requested changes.

@AdityaGarg8 AdityaGarg8 merged commit f660897 into t2linux:master Feb 24, 2024
1 check passed
@sharpenedblade sharpenedblade deleted the update-firmware-script branch April 30, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants