Fix review

t2linux · Feb 23, 2024 · 56bf3e0 · 56bf3e0
1 parent 91bc11f
commit 56bf3e0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/docs/guides/wifi-bluetooth.md b/docs/guides/wifi-bluetooth.md
@@ -40,10 +40,9 @@ You have two options here. You can follow either of the two, its purely based on
 - The second method is to simply run the following commands on Linux :-
 
   ```sh
-  sudo umount /dev/nvme0n1p1
-  sudo mkdir -p /tmp/apple-wifi-efi
-  sudo mount /dev/nvme0n1p1 /tmp/apple-wifi-efi
-  bash /tmp/apple-wifi-efi/firmware.sh
+    sudo mkdir -p /tmp/apple-wifi-efi
+    sudo mount /dev/nvme0n1p1 /tmp/apple-wifi-efi
+    bash /tmp/apple-wifi-efi/firmware.sh
   ```
 
 #### For those who don’t know how to run a script

diff --git a/docs/tools/firmware.sh b/docs/tools/firmware.sh
@@ -45,11 +45,11 @@ case "$os" in
 			fi
 		fi
 		echo "Copying this script to the ESP"
-		cp "$0" "/Volumes/${EFILABEL}/firmware.sh"|| (echo -e "\nFailed to copy script.\nPlease copy the script manually to the EFI partition using Finder\n" && echo && read -p "Press enter after you have copied" && echo)
+		cp "$0" "/Volumes/${EFILABEL}/firmware.sh"|| (echo -e "\nFailed to copy script.\nPlease copy the script manually to the EFI partition using Finder\nMake sure the name of the script is firmware.sh in the EFI partition\n" && echo && read -p "Press enter after you have copied" && echo)
 		echo "Unmounting the EFI partition"
 		sudo diskutil unmount "/Volumes/${EFILABEL}/"
 		echo
-		echo -e "Run the following commands or run this script itself in Linux now to set up Wi-Fi:\n\n    sudo mkdir -p /tmp/apple-wifi-efi\n    sudo mount /dev/nvme0n1p1 /tmp/apple-wifi-efi\n    /tmp/apple-wifi-efi/firmware.sh\n"
+		echo -e "Run the following commands or run this script itself in Linux now to set up Wi-Fi:\n\n    sudo mkdir -p /tmp/apple-wifi-efi\n    sudo mount /dev/nvme0n1p1 /tmp/apple-wifi-efi\n    bash /tmp/apple-wifi-efi/firmware.sh\n"
 		;;
 	(Linux)
 		echo "Detected Linux"
@@ -69,7 +69,6 @@ case "$os" in
     	python3 $0 $workdir $workdir/firmware-renamed.tar &> /dev/null
 			sudo tar -xC /lib/firmware -f $workdir/firmware-renamed.tar
 		fi
-		echo "Installing extra firmware"
 		for file in "$mountpoint/brcmfmac4364b2-pcie.txt" \
 			"$mountpoint/brcmfmac4364b2-pcie.txcap_blob"
 		do
@@ -104,7 +103,7 @@ case "$os" in
 		sudo umount $mountpoint
 		sudo rm -r $workdir/*
 		sudo rmdir $mountpoint
-		echo "Reloading Wi-Fi drivers"
+		echo "Reloading Wi-Fi and Bluetooth drivers"
 		sudo modprobe -r brcmfmac_wcc
 		sudo modprobe -r brcmfmac
 		sudo modprobe brcmfmac