Merge pull request #46 from t-brandt/fix/plotting_proper_motion_units

proper motion plotting bugfix.
t-brandt · Apr 29, 2022 · a2edef8 · a2edef8
2 parents 8e51a3f + 28a3373
commit a2edef8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,8 @@
+1.1.2 (2022-04-28)
+------------------
+- Bugfix for plotting proper motions. When the internals changed to mas/yr with 1.1.1, the plotting 
+was still done in units of mas/day. 
+
 1.1.1 (2022-04-21)
 ------------------
 - Added support for the Java Tool IAD (colloquially called hip21).

diff --git a/orvara/orbit.pyx b/orvara/orbit.pyx
@@ -558,7 +558,7 @@ cdef class Model:
         for i in range(self.nAst):
             dRA_dt[i] = B * ((- self.sinEA[i]) * (2*pi/par.per) / (1 - par.ecc * self.cosEA[i])) + G * (sqrt(1 - par.ecc**2) * (self.cosEA[i]) * (2*pi/par.per) / (1 - par.ecc * self.cosEA[i]))
             dDec_dt[i] = A * ((- self.sinEA[i]) * (2*pi/par.per) / (1 - par.ecc * self.cosEA[i])) + F * (sqrt(1 - par.ecc**2) * (self.cosEA[i]) * (2*pi/par.per) / (1 - par.ecc * self.cosEA[i]))
-        return dRA_dt, dDec_dt
+        return dRA_dt*365.25, dDec_dt*365.25  # convert to mas/yr
 
     def free(self):
         PyMem_Free(self.dRA_H1)

diff --git a/setup.py b/setup.py
@@ -7,7 +7,7 @@
 
 setup(name='orvara',
       ext_modules=cythonize(modules),
-      version='1.1.1',
+      version='1.1.2',
       python_requires='>=3.5',
       package_dir={'orvara': 'orvara'},
       install_requires=['numpy>=1.13', 'htof>=1.1.0', 'emcee', 'ptemcee',