Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subworld-aware teleportation and location query commands #2195

Merged
merged 3 commits into from
Oct 21, 2024
Merged

subworld-aware teleportation and location query commands #2195

merged 3 commits into from
Oct 21, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 20, 2024 •
edited
Loading 

scripts/play.sh --scenario scenarios/Testing/144-subworlds/teleport-and-query.yaml --autoplay

@github-actions github-actions bot mentioned this pull request Oct 20, 2024
Closed
@kostmo kostmo changed the title subworld-aware teleportation command subworld-aware teleportation and location query commands Oct 20, 2024
@kostmo kostmo force-pushed the command/subworld-aware-teleportation-command branch from 5e99459 to f821472 Compare October 21, 2024 00:11
@kostmo kostmo force-pushed the command/subworld-aware-teleportation-command branch from f821472 to a26d960 Compare October 21, 2024 00:53
@kostmo kostmo marked this pull request as ready for review October 21, 2024 01:25
@kostmo kostmo requested a review from byorgey October 21, 2024 01:27
byorgey
byorgey approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and a very sensible generalization.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 21, 2024
@mergify mergify bot merged commit e905049 into main Oct 21, 2024
15 checks passed
@mergify mergify bot deleted the command/subworld-aware-teleportation-command branch October 21, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey