-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use wall rendering #2153
use wall rendering #2153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kostmo, maybe this should be part of a tracking issue to get rid of old walls?
@@ -92,7 +92,7 @@ entities: | |||
char: '#' | |||
description: | |||
- Unmovable barrier | |||
properties: [known, unwalkable] | |||
properties: [known, unwalkable, boundary] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one will probably look strange with connected walls, won't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an interesting challenge to specify how such a more sophisticated renderer should work. Like, I think I have an intuitive idea of what I think the result should look like (though it may not be the same as yours), but I think there is some interesting graph theory needed to compute the right drawing. I will see if I can give it some thought.
We can't quite get rid of all walls, as illustrated by the bucket brigade challenge map. |
Makes use of #1285 to simplify wall rendering in several scenarios.