Test runtime log does not contain errors

[xsebek]

• closes Check scenario ordering errors in CI #1449

[xsebek]

The CI should now fail like this:

[byorgey]

Looks good to me!

[xsebek]

It seems there is an error about achievements in CI:

Tests
  Test runtime log does not contain errors:                                                                    FAIL
    test/integration/Main.hs:112:
    Error was produced during loading: Failed to acquire achievement from path '.':
      The 0 is missing!
    Use -p '/Test runtime log does not contain errors/' to rerun this test only.

@kostmo any ideas?

[byorgey]

I don't understand how that message is even possible. It is coming from here:

swarm/src/Swarm/Game/Failure.hs

Line 93 in 8ed5b92

DoesNotExist e -> "The" <+> ppr e <+> "is missing!"

The e on that line of code is an Entry:

swarm/src/Swarm/Game/Failure.hs

Lines 40 to 44 in 8ed5b92

	data Entry = Directory | File
	deriving (Eq, Show)
	data LoadingFailure
	= DoesNotExist Entry

I don't understand how calling ppr on an Entry could produce 0...

...oh, lol, the PrettyPrec Entry instance is wrong:

swarm/src/Swarm/Game/Failure.hs

Lines 88 to 89 in 8ed5b92

	instance PrettyPrec Entry where
	prettyPrec = const . prettyShowLow

It looks so plausible!

Fixing this will not fix the error but at least the error message will be more reasonable.

[xsebek]

I restarted ghc-9.6.2 job, it should at least show a better error message, but will still need more investigation.

[byorgey]

I don't know if rerunning the test will pick up the bug fix unless we manually merge main into this branch (?).

[xsebek]

@byorgey I thought it was running tests on merged state, but maybe I remembered that wrong. 😕

[byorgey]

Ah, no, it looks like you're right. The failed test now has a correct error message.

[xsebek]

(That's because I force-pushed the rebased branch 😉)

Seems like we are missing the achievements directory in CI. 🤔

swarm/src/Swarm/Game/Achievement/Persistence.hs

Lines 49 to 51 in 49903de

	else do
	warn $ AssetNotLoaded Achievement "." $ DoesNotExist Directory
	return []

If I understand it correctly, having no achievements before playing should not be an error. 🤔

[byorgey]

Ah, yes, that makes sense. Not having the achievements directory exist is just the normal state of affairs when playing the game for the first time. It should not give a warning. I think we should just get rid of that else block.