Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrettyPrec Entry instance prints precedence level instead of Entry #1462

Closed
byorgey opened this issue Aug 24, 2023 · 0 comments · Fixed by #1463
Closed

PrettyPrec Entry instance prints precedence level instead of Entry #1462

byorgey opened this issue Aug 24, 2023 · 0 comments · Fixed by #1463
Assignees
@byorgey
Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. L-Pretty-printing Pretty-printing ASTs or values into a string representation.

Comments

@byorgey
Copy link
Member

byorgey commented Aug 24, 2023

I don't understand how calling ppr on an Entry could produce 0...

...oh, lol, the PrettyPrec Entry instance is wrong:

Originally posted by @byorgey in #1457 (comment)
@byorgey byorgey added Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. L-Pretty-printing Pretty-printing ASTs or values into a string representation. labels Aug 24, 2023
@byorgey byorgey self-assigned this Aug 24, 2023
byorgey added a commit that referenced this issue Aug 24, 2023
@byorgey
fix PrettyPrec Entry instance
dfa61df 
Closes #1462.
@byorgey byorgey mentioned this issue Aug 24, 2023
Merged
@mergify mergify bot closed this as completed in #1463 Aug 24, 2023
mergify bot pushed a commit that referenced this issue Aug 24, 2023
@byorgey
fix PrettyPrec Entry instance (#1463)
d0783bc 
Closes #1462.

To demonstrate, *e.g.* temporarily remove `names.txt`.  Without this patch, you will get an error message saying `The 0 is missing!`.  With this patch, it now correctly says `The file is missing!`.
@xsebek xsebek mentioned this issue Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byorgey byorgey

Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. L-Pretty-printing Pretty-printing ASTs or values into a string representation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix PrettyPrec Entry instance swarm-game/swarm
1 participant
@byorgey