Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated backport of #1625: Remove broker resync period for ServiceImport and #1628

Conversation

tpantelis
Copy link
Contributor

Backport of #1625 on release-0.16.

#1625: Remove broker resync period for ServiceImport and

For details on the backport process, see the backport requests page.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1628/tpantelis/automated-backport-of-#1625-upstream-release-0.16
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

This has proven to be problematic at larger scale, significantly
increasing latencies due to the rate limiting. It was put in to
easily handle a hypothetical, unlikely edge case where a service
namespace is deleted then recreated but the potential performance
hit to handle it in this manner isn't worth it. Now that the
resource syncer can watch namespaces, we can handle it there.

Fixes submariner-io#1623

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis force-pushed the automated-backport-of-#1625-upstream-release-0.16 branch from 5a93f9b to 954d6fd Compare August 26, 2024 12:35
@tpantelis tpantelis enabled auto-merge (rebase) August 26, 2024 12:35
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 27, 2024
@tpantelis tpantelis merged commit dc36597 into submariner-io:release-0.16 Aug 27, 2024
30 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1628/tpantelis/automated-backport-of-#1625-upstream-release-0.16]

@tpantelis tpantelis deleted the automated-backport-of-#1625-upstream-release-0.16 branch August 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants