Remove broker resync period for ServiceImport and EndpointSlices

This has proven to be problematic at larger scale, significantly
increasing latencies due to the rate limiting. It was put in to
easily handle a hypothetical, unlikely edge case where a service
namespace is deleted then recreated but the potential performance
hit to handle it in this manner isn't worth it. Now that the
resource syncer can watch namespaces, we can handle it there.

Fixes #1623

Signed-off-by: Tom Pantelis <[email protected]>

pkg/agent/controller/controller_suite_test.go

@@ -109,8 +109,6 @@ func init() {
 	if err != nil {
 		panic(err)
 	}
-
-	controller.BrokerResyncPeriod = time.Millisecond * 100
 }
 
 func TestController(t *testing.T) {

pkg/agent/controller/endpoint_slice.go

@@ -70,7 +70,6 @@ func newEndpointSliceController(spec *AgentSpecification, syncerConfig broker.Sy
 				c.enqueueForConflictCheck(context.TODO(), obj.(*discovery.EndpointSlice), op)
 				return false
 			},
-			BrokerResyncPeriod: BrokerResyncPeriod,
 		},
 	}
 

pkg/agent/controller/service_import.go

@@ -98,7 +98,6 @@ func newServiceImportController(spec *AgentSpecification, syncerMetricNames Agen
 		Transform:        controller.onRemoteServiceImport,
 		OnSuccessfulSync: controller.serviceImportMigrator.onSuccessfulSyncFromBroker,
 		Scheme:           syncerConfig.Scheme,
-		ResyncPeriod:     BrokerResyncPeriod,
 		SyncCounterOpts: &prometheus.GaugeOpts{
 			Name: syncerMetricNames.ServiceImportCounterName,
 			Help: "Count of imported services",

pkg/agent/controller/types.go

@@ -20,7 +20,6 @@ package controller
 
 import (
 	"sync"
-	"time"
 
 	"github.com/submariner-io/admiral/pkg/federate"
 	"github.com/submariner-io/admiral/pkg/syncer"
@@ -40,8 +39,6 @@ const (
 	portConflictReason = "ConflictingPorts"
 )
 
-var BrokerResyncPeriod = time.Minute * 2
-
 type EndpointSliceListerFn func(selector k8slabels.Selector) []runtime.Object
 
 type converter struct {