Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting unknown_cost_value to 100 #41

Merged
merged 2 commits into from
Mar 11, 2015

Conversation

Jailander
Copy link
Member

solves issue #39

@bfalacerda
Copy link
Contributor

We also have the allow_unknown param for the global planner that could be set to false. That solution looks cleaner than this one, have you tried it?

@Jailander
Copy link
Member Author

I have done some testing with this and haven't been able to make it plan over unknown areas yet, so I guess that works, I'll keep testing.

As for the allow_unknown parameter apparently is the one that actually considers unknown cells in the cost_map as unknown if not it just gives them obstacle cost, but it does seem a bit hacky as seen in https://github.com/ros-planning/navigation/blob/indigo-devel/navfn/src/navfn.cpp#L251

I'll test changing both today and change the pull request if needed, so don't merge just yet

@marc-hanheide
Copy link
Member

@Jailander said:

I'll test changing both today and change the pull request if needed, so don't merge just yet

So?

@Jailander
Copy link
Member Author

This works and has been tested

@marc-hanheide
Copy link
Member

how is this related to strands-project/strands_navigation#188?

@Jailander
Copy link
Member Author

It isn't, this has been tested and is ready to be merged, why?

@marc-hanheide
Copy link
Member

sorry... got lost ;-)

marc-hanheide added a commit that referenced this pull request Mar 11, 2015
setting unknown_cost_value to 100
@marc-hanheide marc-hanheide merged commit 2917d2c into strands-project:hydro-devel Mar 11, 2015
@Jailander
Copy link
Member Author

Hahaha Ok, me too :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants