Optimize decommiting last FRI layer using univariate FFT

[andrewmilson]

This change is 

[andrewmilson]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Optimize decommiting last FRI layer using univariate FFT #133 : 2 dependent PRs (#152 , #153 ) 👈
• Add verifier #127
• Compute FRI quotients #118
• Add CanonicCoset #117
• Add unreduced field arithmetic #116
• Refactor FRI implementation #115
• Refactor Coset with CirclePointIndex #114
• Add formatting to scarb.toml #113
• Update to latest Cairo version #112
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[ilyalesokhin-starkware]

stwo_cairo_verifier/src/poly/utils.cairo line 35 at r1 (raw file):

    let lhs_val = fold(values, folding_factors, index, level + 1, n / 2);
    let rhs_val = fold(values, folding_factors, index + n / 2, level + 1, n / 2);
    return lhs_val + rhs_val.mul_m31(*folding_factors[level]);

This change is independent of the other changes, right?

Code quote:

 return lhs_val + rhs_val.mul_m31(*folding_factors[level]);

[ilyalesokhin-starkware]

stwo_cairo_verifier/src/fri.cairo line 550 at r1 (raw file):

    #[test]
    fn test_fold_line_1() {
        let domain = LineDomainImpl::new_unchecked(

Why not keep the new function and use it here?

Code quote:

  let domain = LineDomainImpl::new_unchecked(

[andrewmilson]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti and @ilyalesokhin-starkware)

---

stwo_cairo_verifier/src/fri.cairo line 550 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Why not keep the new function and use it here?

Done.

---

stwo_cairo_verifier/src/poly/utils.cairo line 35 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

This change is independent of the other changes, right?

Yes my bad should have put in a seperate PR

[ilyalesokhin-starkware]

stwo_cairo_verifier/src/poly/line.cairo line 115 at r1 (raw file):

    while domain_i != 0 {
        domain_i -= 1;
        let domain = domains[domain_i];

Suggestion:

    let domains_span = domains.span()
    while Some(domain) = domains_span.pop_back() {

[ilyalesokhin-starkware]

Reviewed 1 of 4 files at r1.
Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @Alon-Ti, @andrewmilson, and @ilyalesokhin-starkware)

[andrewmilson]

Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @Alon-Ti and @ilyalesokhin-starkware)

---

stwo_cairo_verifier/src/poly/line.cairo line 115 at r1 (raw file):

    while domain_i != 0 {
        domain_i -= 1;
        let domain = domains[domain_i];

Done.