Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FriVerifier::decommit_inner_layers #134

Open
wants to merge 2 commits into
base: 11-04-Add_README_for_cairo_verifier
Choose a base branch
from

Conversation

andrewmilson
Copy link
Contributor

No description provided.

@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 9623734 to 38b73f4 Compare October 24, 2024 02:33
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 38b73f4 to 940580e Compare October 24, 2024 02:40
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 940580e to 72c02f8 Compare October 24, 2024 03:01
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 72c02f8 to 79a0f90 Compare October 24, 2024 03:02
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 79a0f90 to 47b090e Compare October 24, 2024 15:04
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 47b090e to 166b918 Compare October 24, 2024 15:06
@andrewmilson andrewmilson marked this pull request as ready for review October 24, 2024 15:08
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 166b918 to 9cc2ecb Compare October 24, 2024 15:23
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 9cc2ecb to 50fa500 Compare October 27, 2024 23:44
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 50fa500 to 728621e Compare October 29, 2024 03:33
@andrewmilson andrewmilson force-pushed the 10-22-Optimizations branch 2 times, most recently from c4bddaa to c7df8ae Compare November 5, 2024 01:02
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from 728621e to d5170f2 Compare November 5, 2024 01:19
@andrewmilson andrewmilson changed the base branch from 10-22-Optimizations to 11-04-Add_README_for_cairo_verifier November 5, 2024 01:19
@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch from fe6591b to e2b4e58 Compare November 5, 2024 01:21
@andrewmilson andrewmilson force-pushed the 10-23-Refactor_FriVerifier_decommit_inner_layers branch from d5170f2 to e5aac08 Compare November 5, 2024 01:21
@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/src/fri.cairo line 213 at r1 (raw file):

#[derive(Drop)]
pub struct FriProof {
    pub inner_layers: Array<FriLayerProof>,

Is there ar reason for this not to be a span?

Suggestion:

Span<FriLayerProof>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants