Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map #507

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map #507

merged 7 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Move EmptyPythonVisitor to its own header file

    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6020ba4 View commit details
    Browse the repository at this point in the history

  2. Map enhancements: split GenericMapPythonVisitor into its own file map… 

    ….hpp, add visitor arg to ::expose() with overloads
    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2a92f7f View commit details
    Browse the repository at this point in the history

  3. Rename overload_base_get_item_for_std_map to overload_base_get_item_f… 

    …or_map

+ move out of details namespace
+ keep details::overload_base_get_item_for_std_map symbol as a typedef, marked deprecated
    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    997911a View commit details
    Browse the repository at this point in the history

  4. is this a fix

    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a81f79f View commit details
    Browse the repository at this point in the history

  5. it was not a fix

    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a99c268 View commit details
    Browse the repository at this point in the history

  6. add include guard for empty-visitor.hpp

    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    aa2c54b View commit details
    Browse the repository at this point in the history

  7. Move overload_base_get_item_for_std_map<> using-typedef back to std-m… 

    …ap.hpp
    @ManifoldFR @jcarpent
    ManifoldFR authored and jcarpent committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e03f6b2 View commit details
    Browse the repository at this point in the history