Map enhancements: add visitor arg to ::expose() with overloads, rename overload_base_get_item_for_std_map
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edantec can you please compile this branch to see if it resolves Simple-Robotics/aligator/issues/209 when you use the |
ManifoldFR
changed the title
overload_base_get_item_for_std_map
ManifoldFR
added a commit
to Simple-Robotics/aligator
that referenced
this pull request
Sep 23, 2024
This commit requires stack-of-tasks/eigenpy#507 to be merged.
ManifoldFR
added a commit
to Simple-Robotics/aligator
that referenced
this pull request
Sep 23, 2024
This commit requires stack-of-tasks/eigenpy#507 to be merged. Resolves #209
Done, everything is working well |
note: it ended up not working for |
jorisv
requested changes
Sep 25, 2024
….hpp, add visitor arg to ::expose() with overloads
…or_map + move out of details namespace + keep details::overload_base_get_item_for_std_map symbol as a typedef, marked deprecated
jcarpent
force-pushed
the
topic/map-enhancements
branch
from
b8fe774
to
e03f6b2
Compare
jcarpent
approved these changes
Sep 26, 2024
jorisv
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
eigenpy/map.hppEmptyPythonVisitorto its own header fileeigenpy/utils/empty-visitoroverload_base_get_item_for_std_mapto drop thestdmention, move out ofeigenpy::detailsnamespaceResolves #506